Support PEP-604 style unions in decorator annotations #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
benhgreen
force-pushed
the
support-new-unions
branch
from
9d7bf92 to
5dffeff
Compare
These unions were introduced in Python 3.10 and do not define __origin__, so some extra checks are necessary to identify then. Since there is not yet a 3.10 build, a somewhat hacky test was added to simulate one of these new Unions. Resolves Instagram#414.
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
=======================================
Coverage 94.31% 94.31%
=======================================
Files 232 232
Lines 22606 22624 +18
=======================================
+ Hits 21321 21338 +17
- Misses 1285 1286 +1
Continue to review full report at Codecov.
|
benhgreen
force-pushed
the
support-new-unions
branch
from
5dffeff to
48d5872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These unions were introduced in Python 3.10 and do not define
__origin__,so some extra checks are necessary to identify then. Since there is not
yet a 3.10 build, a somewhat hacky test was added to simulate one of
these new Unions.
Resolves #414.
Test Plan
Existing + new unittests. Also tested locally in an environment supporting new Unions.