Walrus operator's left hand side now has STORE expression context #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
- Coverage 94.32% 94.31% -0.01%
==========================================
Files 232 232
Lines 22641 22657 +16
==========================================
+ Hits 21355 21368 +13
- Misses 1286 1289 +3
Continue to review full report at Codecov.
|
thatch
reviewed
Dec 15, 2020
| if x := y: | ||
| pass | ||
| """ | ||
| wrapper = MetadataWrapper(parse_module(dedent(code))) |
There was a problem hiding this comment.
The version can be decoupled; if you want, this will let the test run everywhere:
parse_module(
dedent(code),
config=cst.PartialParserConfig(python_version="3.8"),
)
thatch
reviewed
Dec 16, 2020
| @@ -1609,6 +1610,27 @@ def test_no_out_of_order_references_in_global_scope(self) -> None: | |||
| ), | |||
| ) | |||
|
|
|||
| def test_walrus_accesses(self) -> None: | |||
| if sys.version_info < (3, 8): | |||
There was a problem hiding this comment.
This one is not as easy, I'd have to plumb the parser config through some helper functions, so I thought it's fine to keep it as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes scope provider assign a
STOREexpression context to the left hand side of a walrus operator. So, in anx := yexpression,xshould haveExpressionContext.STOREas its expression context metadata.Test Plan
Added unit tests.