-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix codemodding on windows #495
Conversation
Hi @Josverl! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thx for contributing! :) |
After looking at the pre-OSS blame for this, it seems like the use of |
Looks like that particular error has been resolved, but I see a different one today. In any case, we should fix this issue internally |
Summary
running codemodding fails due to passing an empty environment
env={}
rather thanenv=None
according to the Python spec.Note If specified, env must provide any variables required for the program to execute. On Windows, in order to run a side-by-side assembly the specified env must include a valid SystemRoot.
by specifying env=None things work smoothly on Windows 10
fixes: #494
Test Plan
I have only performed limited testing on Windows, but this should be validated across all supported platforms.
My assumption that this is already part of the CI/CD tests