implement PEP-654: except* #571
Conversation
facebook-github-bot
added
the
CLA Signed
|
@stroxler xmas treat for you :) |
Codecov Report
@@ Coverage Diff @@
## main #571 +/- ##
==========================================
+ Coverage 94.62% 94.65% +0.03%
==========================================
Files 240 240
Lines 23389 23579 +190
==========================================
+ Hits 22132 22319 +187
- Misses 1257 1260 +3
Continue to review full report at Codecov.
|
| @@ -498,6 +499,13 @@ parser! { | |||
| make_try(kw, b, ex, el, f) | |||
| } | |||
|
|
|||
| // Note: this is separate because TryStar is a different type in LibCST | |||
| rule try_star_stmt() -> TryStar<'a> | |||
There was a problem hiding this comment.
The official grammar has this as a variant under try_stmt. We're sure it's worth diverging? I can see some value in it since the actual AST node variant is different, but there's a price we'll pay keeping things in sync for every rule that diverges.
There was a problem hiding this comment.
Not 100% sure it's worth it, I was a bit lazy and wanted to avoid an additional enum layer just so we can have a single rule.
There was a problem hiding this comment.
Oh are the rules tied more tightly to types in the rust PEG library than in C?
In CPython it's a single PEG variant, but two different AST types still
Summary
This PR adds support for the new grouped exception handling mechanism introduced by PEP-654. The only significant difference between AST and this CST implementation is a new
ExceptStarHandlertype, which differs fromExceptHandlerin:typeattribute to be always present (it can't beNone)exceptkeyword and the*The new syntax can only be parsed by the Rust parser (currently needing
LIBCST_PARSER_TYPE=nativeenvironment variable).Test Plan