[native] Don't redundantly nest StarredElement inside another Element #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
isidentical
force-pushed
the
dont-nest-starred-expr
branch
from
c77da54 to
6e800db
Compare
Codecov Report
@@ Coverage Diff @@
## main #624 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 245 245
Lines 25256 25256
=======================================
Hits 23940 23940
Misses 1316 1316
Continue to review full report at Codecov.
|
stroxler
approved these changes
Jan 23, 2022
There was a problem hiding this comment.
Looks good to me, thanks @isidentical!
cc @zsol for awareness, but since this is just making the native parser match existing behavior I'm going to go ahead and merge it
This was referenced Jan 28, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #623
Test Plan
Added 2 tests, which fail with the current
mainbut pass with this patch.