Proxy both parentheses in some pattern matching nodes #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #626 +/- ##
==========================================
- Coverage 94.78% 94.77% -0.01%
==========================================
Files 245 245
Lines 25256 25268 +12
==========================================
+ Hits 23940 23949 +9
- Misses 1316 1319 +3
Continue to review full report at Codecov.
|
isidentical
force-pushed
the
proxy-right-parens-too
branch
from
4fdf323 to
8c095c8
Compare
isidentical
force-pushed
the
proxy-right-parens-too
branch
from
8c095c8 to
5f073ca
Compare
isidentical
force-pushed
the
proxy-right-parens-too
branch
from
5f073ca to
9110754
Compare
|
@zsol I've been accepting all the patches coming in that fix cut-and-dry syntax bugs. Proxying is more of a LibCST internal thing so I'll leave this for you to review, unless you'd rather I do it. |
zsol
approved these changes
Jan 25, 2022
Comment on lines
+2896
to
+2899
| @rpar.setter | ||
| def rpar(self, value: Sequence[RightParen]) -> None: | ||
| # pyre-fixme[41]: Cannot reassign final attribute `rpar`. | ||
| self.value.rpar = value |
There was a problem hiding this comment.
hmm, in retrospect I think we don't need these setters, these dataclasses are frozen. I'll follow up.
This was referenced Jan 28, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This patch adds support for proxying the right parentheses to the underlying child node, so it would be consistent with the left one. Resolves #625.
Test Plan
Added a test about a case that was broken before.