Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relax validation rules on decorators #926

Merged
merged 2 commits into from
May 23, 2023
Merged

relax validation rules on decorators #926

merged 2 commits into from
May 23, 2023

Conversation

jakkdl
Copy link
Contributor

@jakkdl jakkdl commented May 22, 2023 •
edited by zsol
Loading

relax validation on decorators

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 22, 2023
@zsol zsol changed the title relax validation rules on decorators relax validation on decorators May 22, 2023
@zsol zsol changed the title relax validation on decorators relax validation rules on decorators May 22, 2023
@zsol zsol force-pushed the relaxed_grammar_on_decorator_486 branch from ff1a680 to 7ea0596 Compare May 22, 2023 21:41
@zsol
Copy link
Member

zsol commented May 23, 2023

Thanks! I also relaxed the type of Decorator.decorator and added a test for this as well.

@zsol zsol merged commit 38b708b into Instagram:main May 23, 2023
@jakkdl
Copy link
Contributor Author

jakkdl commented May 23, 2023

Ah, good catch! 🚀

@jakkdl jakkdl deleted the relaxed_grammar_on_decorator_486 branch May 23, 2023 18:32
@Zac-HD Zac-HD mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakkdl @zsol @facebook-github-bot