Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model_inputs.xlsx #236

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Update model_inputs.xlsx #236

merged 2 commits into from
Feb 24, 2023

Conversation

rhanIDM
Copy link
Collaborator

@rhanIDM rhanIDM commented Feb 22, 2023

Removed outdated unused sheets. No breaking changes.

Removed outdated unused sheets. No breaking changes.
@rhanIDM rhanIDM requested review from MeWu-IDM and removed request for MeWu-IDM February 22, 2023 02:21
@rhanIDM rhanIDM marked this pull request as draft February 22, 2023 02:32
@rhanIDM
Copy link
Collaborator Author

rhanIDM commented Feb 22, 2023

Will add regression test on this branch later this week.

* adding regression tests to use researcher's model

* add missing script

* remove deprecated context

* use namespace
@rhanIDM rhanIDM marked this pull request as ready for review February 24, 2023 00:21
@rhanIDM rhanIDM requested a review from MeWu-IDM February 24, 2023 00:22
Copy link
Collaborator

@MeWu-IDM MeWu-IDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not break current simulation

@MeWu-IDM MeWu-IDM merged commit 72f8e0a into main Feb 24, 2023
@MeWu-IDM MeWu-IDM deleted the clean-model_inputs branch May 15, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants