-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rate limits caps for fertility, mortality, and prevalence rates #273
Conversation
@MeWu-IDM : lots of snapshots have changed. Over to you! |
@MeWu-IDM : Just checking that you saw that the NA change limits problem should be addressed now. |
} | ||
|
||
.applyRateLimits <- function(rates, limits) { | ||
if (!is.null(limits$max)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no checks for max being negative values so this may generate weird results when setting negative max
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to check if limits$max> limit$min, otherwise the logic does not make sense
\item{stochasticParametersSheetName}{Name of Excel sheet holding stochastic | ||
parameters (mean, variance, etc) for different computations} | ||
|
||
\item{changeRateLimitsSheetName}{Name of Excel sheet holding max/min ranges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to update the vignetter/pacehhrh.rmd to have section to explain the ChangeRateLimit spreadsheet based ion #119 logic as they are not very straightforward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving this to issue #246.
@MeWu-IDM : Rate limit validation code has been checked in, and all checks have passed. Over to you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change rate limits work as expected. The documentation for implementation details and expected behavior will be addressed by issue #246.
This is a partial BREAKING CHANGE.
Addresses issue #119 (refer for more details)