gh_84_make_drug_vehicle_issue #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… longer possible. Drug parameters will need to be set in config builder separately from campaign builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed setting drug parameters from inside interventions as it is nolonger possible. Drug parameters will need to be set in config builder separately from campaign builder.
I also changed confusing receiving_drugs_event_name/receiving_drugs_event to receiving_drugs_event_name and "also_deploy_drugs". In some of the functions receiving_drugs_event was the same as receiving_drugs_event_name, but in another, it was a bool that meant that you were also going to distribute drugs. I made that more explicit.
This will be code-breakign changes. Once this is pulled in, code that's using these scripts will need to be updated due to parameter changes: removal of vehicle/drug dictionary parameters and receiving_drugs_event->also_deploy_drugs