-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Enforcer modality-aware #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come this doesn't change the Adversary? Also probably want to test your recursive function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Do you know what happens when input
or target
does not "match" input_adv
? If input_adv
is a list
and input
is a dict? Probably best to assert types right after the isinstance
checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I would consider the comment.
What does this PR do?
This PR makes Enforcer aware of modalities in input, and compatible with existing configs without modality.
Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
pytest tests/test_enforcer.py
Before submitting
pre-commit run -a
command without errorsDid you have fun?
Make sure you had fun coding 🙃