Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Enforcer modality-aware #124

Merged
merged 19 commits into from
Mar 30, 2023
Merged

Make Enforcer modality-aware #124

merged 19 commits into from
Mar 30, 2023

Conversation

mzweilin
Copy link
Contributor

@mzweilin mzweilin commented Mar 29, 2023

What does this PR do?

This PR makes Enforcer aware of modalities in input, and compatible with existing configs without modality.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • pytest tests/test_enforcer.py

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

@mzweilin mzweilin requested a review from dxoigmn March 29, 2023 18:59
Copy link
Contributor

@dxoigmn dxoigmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this doesn't change the Adversary? Also probably want to test your recursive function

mart/attack/enforcer.py Outdated Show resolved Hide resolved
mart/attack/enforcer.py Show resolved Hide resolved
@mzweilin mzweilin requested a review from dxoigmn March 29, 2023 23:40
Copy link
Contributor

@dxoigmn dxoigmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you know what happens when input or target does not "match" input_adv? If input_adv is a list and input is a dict? Probably best to assert types right after the isinstance checks.

tests/test_enforcer.py Outdated Show resolved Hide resolved
tests/test_enforcer.py Show resolved Hide resolved
@mzweilin mzweilin requested a review from dxoigmn March 30, 2023 17:54
dxoigmn
dxoigmn previously approved these changes Mar 30, 2023
Copy link
Contributor

@dxoigmn dxoigmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I would consider the comment.

mart/attack/enforcer.py Outdated Show resolved Hide resolved
@mzweilin mzweilin merged commit eced15b into main Mar 30, 2023
@mzweilin mzweilin deleted the modality_enforcer branch March 30, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants