Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ART Compatibility #42

Closed
wants to merge 3 commits into from
Closed

ART Compatibility #42

wants to merge 3 commits into from

Conversation

mzweilin
Copy link
Contributor

@mzweilin mzweilin commented Jan 6, 2023

What does this PR do?

  • Dump interpolated configs in experiments so that it's easier to load models in Armory/ART.
  • Add prediction_sequence that does not require target input, because ART invokes model.predict(x).
  • Add loss_sequence that mimics the behavior in torchvision.
  • Example of prediction_sequence and loss_sequence.

Fixes #41

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Test A
  • Test B

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

@dxoigmn
Copy link
Contributor

dxoigmn commented Feb 23, 2023

I think we figured out how to do this without modifying MART.

@dxoigmn dxoigmn closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate models in ART
2 participants