Add tests for wait (#511)

IntelPython · Jul 20, 2021 · 849e5c0 · 849e5c0
1 parent c822d80
commit 849e5c0
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/dpctl-capi/source/dpctl_sycl_event_interface.cpp b/dpctl-capi/source/dpctl_sycl_event_interface.cpp
@@ -52,8 +52,15 @@ __dpctl_give DPCTLSyclEventRef DPCTLEvent_Create()
 void DPCTLEvent_Wait(__dpctl_keep DPCTLSyclEventRef ERef)
 {
     // \todo How to handle errors? E.g. when ERef is null or not a valid event.
-    auto SyclEvent = unwrap(ERef);
-    SyclEvent->wait();
+    if (ERef) {
+        auto SyclEvent = unwrap(ERef);
+        if (SyclEvent)
+            SyclEvent->wait();
+    }
+    else {
+        std::cerr << "Cannot wait for the event. DPCTLSyclEventRef as input is "
+                     "a nullptr\n";
+    }
 }
 
 void DPCTLEvent_Delete(__dpctl_take DPCTLSyclEventRef ERef)

diff --git a/dpctl-capi/tests/test_sycl_event_interface.cpp b/dpctl-capi/tests/test_sycl_event_interface.cpp
@@ -56,6 +56,18 @@ struct TestDPCTLSyclEventInterface : public ::testing::Test
     }
 };
 
+TEST_F(TestDPCTLSyclEventInterface, CheckEvent_Wait)
+{
+    EXPECT_NO_FATAL_FAILURE(DPCTLEvent_Wait(ERef));
+}
+
+TEST_F(TestDPCTLSyclEventInterface, CheckWait_Invalid)
+{
+    DPCTLSyclEventRef E = nullptr;
+    EXPECT_NO_FATAL_FAILURE(DPCTLEvent_Wait(E));
+    EXPECT_NO_FATAL_FAILURE(DPCTLEvent_Delete(E));
+}
+
 TEST_F(TestDPCTLSyclEventInterface, CheckEvent_Copy)
 {
     DPCTLSyclEventRef Copied_ERef = nullptr;