Skip to content

Use setup.py for building C++ backend #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PokhodenkoSA opened this issue Oct 19, 2020 · 1 comment · Fixed by #168
Closed

Use setup.py for building C++ backend #145

PokhodenkoSA opened this issue Oct 19, 2020 · 1 comment · Fixed by #168
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@PokhodenkoSA
Copy link
Contributor

For Python users it is more convenient to work with package via setup.py file. It is the standard way to build and develop package.
So building package python setup.py install or developing package python setup.py develop should also build C++ code for backend.
Example: https://github.com/numba/llvmlite
https://github.com/numba/llvmlite/blob/1f25fa723e419e77c325a135e10acfb9b6112e8f/setup.py#L45 - from setup.py call Python script for build CMake
https://github.com/numba/llvmlite/blob/master/ffi/build.py - Python script for build CMake

User can build package via python setup.py install.
Also conda scripts become simpler.
Also developers will not require to create custom scripts for building parts of the project. All parts could be built via setup.py.

@diptorupd
Copy link
Contributor

Thanks @1e-to. I tried it and it is really nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants