Skip to content

Remove build_for_develop.(bat|sh) files from scripts folder #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PokhodenkoSA opened this issue Jan 13, 2021 · 5 comments
Closed

Remove build_for_develop.(bat|sh) files from scripts folder #239

PokhodenkoSA opened this issue Jan 13, 2021 · 5 comments
Assignees
Labels
question Further information is requested

Comments

@PokhodenkoSA
Copy link
Contributor

PokhodenkoSA commented Jan 13, 2021

In scripts folder there are build files for developers but not all developers use it:

As we have now possibility to use python setup.py develop (#145) for build all necessary things via setup.py, can we remove this files?
If this files contain some feature like building in debugging mode or running tests for backend then we could move this features to setup.py script too.

Sometimes developers think that this files are reference of how dpCtl is built. It leads to wrong understanding of dpCtl build procedure.

@diptorupd @reazulhoque @1e-to @vlad-perevezentsev @shssf

@diptorupd
Copy link
Contributor

@PokhodenkoSA Currently the only thing extra the scripts at least on linux is a way to run the test suite for Python and Ctest. I think everything else is there.

@diptorupd
Copy link
Contributor

If this files contain some feature like building in debugging mode or running tests for backend then we could move this features to setup.py script too.

@PokhodenkoSA I will prefer having at least these two options: debug build and running tests cases, before we remove these scripts.

@oleksandr-pavlyk
Copy link
Contributor

I second @diptorupd in vote to keep the script around.

@diptorupd
Copy link
Contributor

@oleksandr-pavlyk revisiting the issue after almost a year. All the infrastructure improvements that have happened since then means I have not used these scripts in a very long time. Time to remove them?

@diptorupd
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants