Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queues_are_compatible signature for list of usm_ndarray instances #1016

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

oleksandr-pavlyk
Copy link
Collaborator

This PR ass dpctl::utils::queues_are_compatible signature for list of usm_ndarray instances.

Instead of the call

   queues_are_compatible(exec_q, {X1.get_queue(), X2.get_queue()})

for usm_ndarray instances X1 and X2, one can now say

   queues_are_compatible(exec_q, {X1, X2})

I verified this locally when compiling https://github.com/oleksandr-pavlyk/kmeans_dpcpp/

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

Instead of call

```c++
   queues_are_compatible(exec_q, {X1.get_queue(), X2.get_queue()})
```

for `usm_ndarray` instances `X1` and `X2`, one can now say

```c++
   queues_are_compatible(exec_q, {X1, X2})
```
@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented Dec 13, 2022

Coverage Status

Coverage remained the same at 82.34% when pulling b02745d on convenience-signature-for-util-function into da56dce on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev0=py310h8c27c75_17 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev0=py310h8c27c75_18 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit 7d1904c into master Dec 14, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the convenience-signature-for-util-function branch December 14, 2022 01:05
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev0=py310h8c27c75_18 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants