Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented and deployed validate_type_for_device<T>(q) #1018

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

oleksandr-pavlyk
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk commented Dec 15, 2022

Implemented and deployed validate_type_for_device<T>(q) utility function.

This check would produce more succinct error message:

In [1]: import dpctl.tensor as dpt

In [2]: dpt.arange(0, 10, dtype='f8')
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
Input In [2], in <cell line: 1>()
----> 1 dpt.arange(0, 10, dtype='f8')

File ~/repos/dpctl/dpctl/tensor/_ctors.py:603, in arange(start, stop, step, dtype, device, usm_type, sycl_queue)
    601     _step = sc_ty(1)
    602 _start = _first
--> 603 hev, _ = ti._linspace_step(_start, _step, res, sycl_queue)
    604 hev.wait()
    605 if is_bool:

RuntimeError: Device Intel(R) Graphics [0x9a49] does not support type 'double'
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

This check would produce more succint error message:

```
In [1]: import dpctl.tensor as dpt

In [2]: dpt.arange(0, 10, dtype='f8')
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
Input In [2], in <cell line: 1>()
----> 1 dpt.arange(0, 10, dtype='f8')

File ~/repos/dpctl/dpctl/tensor/_ctors.py:603, in arange(start, stop, step, dtype, device, usm_type, sycl_queue)
    601     _step = sc_ty(1)
    602 _start = _first
--> 603 hev, _ = ti._linspace_step(_start, _step, res, sycl_queue)
    604 hev.wait()
    605 if is_bool:

RuntimeError: Device Intel(R) Graphics [0x9a49] does not support type 'double'
```
@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 82.34% when pulling e98de4d on check-aspects-before-kernel-submission into 7d1904c on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev0=py310h8c27c75_20 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit b9f02b3 into master Dec 16, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the check-aspects-before-kernel-submission branch December 16, 2022 18:06
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants