Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set DOWNLOAD_EXTRACT_TIMESTAMP FALSE per cmake policy CMP0135 #1045

Merged
merged 7 commits into from
Jan 26, 2023
Merged

Set DOWNLOAD_EXTRACT_TIMESTAMP FALSE per cmake policy CMP0135 #1045

merged 7 commits into from
Jan 26, 2023
+29 −29

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Set DOWNLOAD_EXTRACT_TIMESTAMP FALSE in FetchContet_Declare cmake functions per CML0135-related warning.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1045/index.html

@coveralls
Copy link
Collaborator

coveralls commented Jan 24, 2023 •
edited
Loading

Coverage Status

Coverage: 82.19%. Remained the same when pulling 764fd26 on set-download-extract-timestamps into 3c512ca on master.

@oleksandr-pavlyk oleksandr-pavlyk changed the title Set DOWNLOAD_EXTRACT_TIMESTAMP FALSE per cmake policy CML0135 Set DOWNLOAD_EXTRACT_TIMESTAMP FALSE per cmake policy CMP0135 Jan 24, 2023
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the set-download-extract-timestamps branch from 8b79553 to 5b2a04f Compare January 24, 2023 19:02
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the set-download-extract-timestamps branch from 5b2a04f to 71611b8 Compare January 25, 2023 13:45
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_31 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_32 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the set-download-extract-timestamps branch from dff4ff0 to 35e6a82 Compare January 25, 2023 16:30
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_32 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_33 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk
Removed copying of OpenCL.dll from Python layout to System32
3b31073 
This step is not needed, since OpenCL.dll is on the search path
that Python process is using for library loading.
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_34 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_35 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_36 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the set-download-extract-timestamps branch from cd61b0a to 645cbf0 Compare January 25, 2023 22:17
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_36 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_37 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the set-download-extract-timestamps branch from fcd7bff to 764fd26 Compare January 26, 2023 12:58
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_37 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit a43326d into master Jan 26, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the set-download-extract-timestamps branch January 26, 2023 14:58
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_37 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-pavlyk @coveralls