Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host task cleanup #1111

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Host task cleanup #1111

merged 4 commits into from
Mar 13, 2023

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Mar 13, 2023

Draft pull request for collecting host_tasks throughout dpctl to prevent dangling tasks, which are suspected to cause crashes.
May be related to #1063

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 82.404%. Remained the same when pulling fd9286c on host-task-cleanup into cecfdaa on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_13 ran successfully.
Passed: 46
Failed: 788
Skipped: 280

@ndgrigorian ndgrigorian marked this pull request as ready for review March 13, 2023 16:13
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian

@oleksandr-pavlyk oleksandr-pavlyk merged commit cdf7b2f into master Mar 13, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the host-task-cleanup branch March 13, 2023 21:44
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_35 ran successfully.
Passed: 46
Failed: 788
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants