Handle numpy arrays with usm memory underneath in dpctl.tensor.asarray #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r underneath Copy-with-casting kernel to transfer content of numpy.ndarray to usm_ndarray is implemented using sycl::buffer used on ndarray's data-pointer. The pointer can not be a host-accessible USM pointer for the behavior to be well-defined. This change should fix issue gh-1089
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1117/index.html |
npolina4
approved these changes
Mar 13, 2023
|
Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_30 ran successfully. |
ndgrigorian
approved these changes
Mar 13, 2023
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_30 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-1089
Hardened
_copy_from_numpy_intoto handlenumpy.ndarrayinputs with USMMemory buffer as a base.Copy-with-casting kernel to transfer content of numpy.ndarray to usm_ndarray is implemented using sycl::buffer used on ndarray's data-pointer. The pointer can not be a host-accessible USM pointer for the behavior to be well-defined.
This change should fix gh-1089