Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/dpctl tensor type dispatch namespace #1179

Merged

Conversation

oleksandr-pavlyk
Copy link
Collaborator

This PR moves type dispatching types from dpctl::tensor::detail to dpctl::tensor::type_dispatch namespace.

Incidentally, it also removes static definition of function pointer arrays from include/kernels/boolean_indexing.hpp.
They are actually also defined source/boolean_indexing.cpp.

This change will likely require code changes in downstream projects using "dpctl4pybind11.hpp".

This PR is the foundation for the further work on unary functions and reductions, so I'd appreciate a prompt review.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 83.263%. Remained the same when pulling 0ab2223 on refactoring/dpctl-tensor-type-dispatch-namespace into 4e41318 on master.

@github-actions
Copy link

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_3 ran successfully.
Passed: 120
Failed: 887
Skipped: 109

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked dpnp build with #1383 and no issue.

@oleksandr-pavlyk oleksandr-pavlyk merged commit e7fc039 into master Apr 21, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the refactoring/dpctl-tensor-type-dispatch-namespace branch April 21, 2023 18:16
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_3 ran successfully.
Passed: 120
Failed: 887
Skipped: 109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants