Refactoring/dpctl tensor type dispatch namespace #1179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves type dispatching types from
dpctl::tensor::detail
todpctl::tensor::type_dispatch
namespace.Incidentally, it also removes static definition of function pointer arrays from
include/kernels/boolean_indexing.hpp
.They are actually also defined
source/boolean_indexing.cpp
.This change will likely require code changes in downstream projects using
"dpctl4pybind11.hpp"
.This PR is the foundation for the further work on unary functions and reductions, so I'd appreciate a prompt review.