Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headers from tensor lib to conda package #1185

Merged
merged 2 commits into from
May 25, 2023
Merged

Add headers from tensor lib to conda package #1185

merged 2 commits into from
May 25, 2023

Conversation

antonwolfy
Copy link
Collaborator

@antonwolfy antonwolfy commented Apr 24, 2023 •
edited
Loading

The PR proposes to include header files from tensor library into dpctl conda package.

The headers will be installed by path:

${CONDA_PREFIX}/site-packages/dpctl/tensor/libtensor/include
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@antonwolfy antonwolfy self-assigned this Apr 24, 2023
@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1185/index.html

@coveralls
Copy link
Collaborator

coveralls commented Apr 24, 2023 •
edited
Loading

Coverage Status

Coverage: 84.005% (-0.03%) from 84.034% when pulling 7e2eaba on include_tensor_headers into 18d1728 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_11 ran successfully.
Passed: 120
Failed: 887
Skipped: 109

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the include_tensor_headers branch from 2bcc55e to 7e2eaba Compare May 23, 2023 22:23
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_118 ran successfully.
Passed: 227
Failed: 773
Skipped: 116

antonwolfy
antonwolfy commented May 25, 2023
View reviewed changes
Copy link
Collaborator Author

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR works fine on both Linux and Windows. Thank you @oleksandr-pavlyk !

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review May 25, 2023 21:13
@oleksandr-pavlyk oleksandr-pavlyk merged commit cf431d7 into master May 25, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the include_tensor_headers branch May 25, 2023 21:13
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev2=py310h7bf5fec_9 ran successfully.
Passed: 231
Failed: 769
Skipped: 116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk oleksandr-pavlyk is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @oleksandr-pavlyk