Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using sysroot 2.28 #1208

Conversation

oleksandr-pavlyk
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk commented May 16, 2023

Update meta.yaml to require sysroot_linux-64 >=2.28, and use dppy/label/tools to get it until it comes online from conda-forge

The sysroot packages are from conda-forge/linux-sysroot-feedstock#47, built locally and uploaded to dppy/label/tools for the purpose on unblocking the build.

N.B.: This PR is into feature/elementwise-functions which is presently broken due to default sysroot version, 2.17, is below the minimum version required by DPC++. See gh-1203

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

…el/tools to get it until it comes online from conda-forge
@github-actions
Copy link

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_64 ran successfully.
Passed: 167
Failed: 833
Skipped: 116

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_65 ran successfully.
Passed: 167
Failed: 833
Skipped: 116

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the feature/elementwise-functions-use-2.28 branch 2 times, most recently from 2bf35b1 to 194ab2d Compare May 16, 2023 18:35
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the feature/elementwise-functions-use-2.28 branch 2 times, most recently from 0d5471b to 73282bb Compare May 16, 2023 19:33
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_64 ran successfully.
Passed: 167
Failed: 833
Skipped: 116

This calls crashing test_tensor_elementwise under gdb in batch mode
in CI. gdb call exit code is ignored
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the feature/elementwise-functions-use-2.28 branch from 73282bb to b1495a2 Compare May 16, 2023 21:32
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_64 ran successfully.
Passed: 167
Failed: 833
Skipped: 116

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review May 16, 2023 22:45
@oleksandr-pavlyk oleksandr-pavlyk merged commit 58ff5be into feature/elementwise-functions May 16, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the feature/elementwise-functions-use-2.28 branch May 16, 2023 22:46
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant