Skip to content

Rename all pxd and pyx filenames to start with _ #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Rename all pxd and pyx filenames to start with _ #121

wants to merge 4 commits into from

Conversation

diptorupd
Copy link
Contributor

Closes #38

@diptorupd diptorupd requested a review from PokhodenkoSA October 9, 2020 23:50
@diptorupd diptorupd added this to the gold milestone Oct 9, 2020
@PokhodenkoSA
Copy link
Contributor

@diptorupd could you please resolve conflict?

@PokhodenkoSA PokhodenkoSA mentioned this pull request Oct 19, 2020
Closed
32 tasks
@diptorupd
Copy link
Contributor Author

diptorupd commented Oct 21, 2020 •
edited
Loading

@PokhodenkoSA I see the file names are already changed in master. Should I close this PR?

Never mind, I now see that is not the case.

@PokhodenkoSA
Copy link
Contributor

@PokhodenkoSA I see the file names are already changed in master. Should I close this PR?

This PR has conflict. Maybe it will not add anything new when conflict will be resolved. Also in the issue #38 I describe that this renamings are useful to simplify build sctipt oin setup.py to use one command to build all Cython modules. Previously it was not possible because pyx file and final Cython module should have different names.

@PokhodenkoSA
Copy link
Contributor

We can close it and create a new Issue for improving setup.py.

@diptorupd
Copy link
Contributor Author

@PokhodenkoSA I have rebased it on top of master. Can be squash and merged now.

@diptorupd diptorupd mentioned this pull request Oct 22, 2020
Closed
@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Oct 22, 2020
Merged
@diptorupd diptorupd closed this Oct 23, 2020
@diptorupd diptorupd reopened this Oct 23, 2020
@diptorupd diptorupd closed this Oct 23, 2020
@diptorupd diptorupd deleted the refactor/reorganize_modules branch February 27, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@PokhodenkoSA PokhodenkoSA Awaiting requested review from PokhodenkoSA

Assignees

@diptorupd diptorupd

Labels
None yet
Projects
None yet
Milestone
gold
Development

Successfully merging this pull request may close these issues.

Cython modules should be renamed to have leading underscore
3 participants
@diptorupd @PokhodenkoSA @oleksandr-pavlyk