-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl_elementwise_functions_exp_sin #1216
Conversation
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1216/index.html |
Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_2 ran successfully. |
9396e51
to
0eb7a91
Compare
Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_2 ran successfully. |
Overall looks great, please fix the docstrings and it is ready to go in my opinion. Please wait for @ndgrigorian feedback though. |
Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_3 ran successfully. |
I agree, I think it looks ready once more thorough docstrings are added. Please add more thorough docstrings (in the style of multiply, divide, add, etc.) and I think this PR will be ready. |
I have populate docstring for |
Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_4 ran successfully. |
Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_6 ran successfully. |
812ea72
to
5314ddd
Compare
Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_9 ran successfully. |
- Avoids bug on CPU that results in incorrect result
…ns-real-imag-conj Feature/elementwise functions real imag conj
Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_13 ran successfully. |
Looks good to me. Thank you @vtavana |
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_13 ran successfully. |
In this PR,
dpctl.tensor.sin
anddpctl.tensor.exp
are added and tested.