Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl_elementwise_functions_exp_sin #1216

Merged
merged 6 commits into from
Jun 2, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented May 26, 2023

In this PR, dpctl.tensor.sin and dpctl.tensor.exp are added and tested.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@vtavana vtavana self-assigned this May 26, 2023
@github-actions
Copy link

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_2 ran successfully.
Passed: 249
Failed: 751
Skipped: 116

@vtavana vtavana force-pushed the feature/elementwise-functions-sin-exp branch from 9396e51 to 0eb7a91 Compare May 26, 2023 01:28
@coveralls
Copy link
Collaborator

coveralls commented May 26, 2023

Coverage Status

coverage: 84.035% (+0.02%) from 84.019% when pulling 18d1641 on feature/elementwise-functions-sin-exp into 1adbaa0 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_2 ran successfully.
Passed: 248
Failed: 752
Skipped: 116

@oleksandr-pavlyk
Copy link
Collaborator

Overall looks great, please fix the docstrings and it is ready to go in my opinion. Please wait for @ndgrigorian feedback though.

@vtavana vtavana requested a review from ndgrigorian May 26, 2023 14:46
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_3 ran successfully.
Passed: 248
Failed: 752
Skipped: 116

@ndgrigorian
Copy link
Collaborator

I agree, I think it looks ready once more thorough docstrings are added.

Please add more thorough docstrings (in the style of multiply, divide, add, etc.) and I think this PR will be ready.

@oleksandr-pavlyk
Copy link
Collaborator

I have populate docstring for abs. Please modify other unary functions using the same template, including functions added in this PR.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_4 ran successfully.
Passed: 248
Failed: 752
Skipped: 116

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_6 ran successfully.
Passed: 248
Failed: 752
Skipped: 116

@vtavana vtavana force-pushed the feature/elementwise-functions-sin-exp branch from 812ea72 to 5314ddd Compare May 31, 2023 04:17
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_9 ran successfully.
Passed: 272
Failed: 728
Skipped: 116

vtavana and others added 4 commits June 1, 2023 19:21
- Avoids bug on CPU that results in incorrect result
…ns-real-imag-conj

Feature/elementwise functions real imag conj
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_13 ran successfully.
Passed: 273
Failed: 727
Skipped: 116

@oleksandr-pavlyk
Copy link
Collaborator

Looks good to me. Thank you @vtavana

@vtavana vtavana merged commit 1596a13 into master Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_13 ran successfully.
Passed: 274
Failed: 726
Skipped: 116

@vtavana vtavana deleted the feature/elementwise-functions-sin-exp branch June 4, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants