Return default floating point type of the device in dpctl.tensor.astype when newdtype=None #1262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes minor changes to
dpctl.tensor.astype
function by replacing the gettingtarget_dtype
.The old implementation did not consider whether the device where input array is allocated supported double-precision floating point types and returned
float64
forNone
type which raisedValueError
.This PR uses
_get_dtype
function from dpctl.tensor._ctors which fixes wrong behavior.For
None
returns default floating point type supported by device.For all other types returns
dpt.dtype(dtype)