Set default dtype of usm_ndarray depending on capabilities of device #1265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue of creating
usm_ndarray
withoutdtype
argument. The default value ofdtype
in__cinit__
ofusm_ndarray
is defined asdtype='f8'
which raised an exception onIris Xe
which does not support 64-bit precision floating point type.Idea of this PR is to change default value
dtype="f8"
todtype=None
and return default floating point type supported by the device whendtype=None
.Note:
I'm not sure if it's correct to get device using
dpctl.SyclDevice()
when queue is unknown.