Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl_elementwise_func_round #1299

Merged
merged 2 commits into from
Jul 26, 2023
Merged

impl_elementwise_func_round #1299

merged 2 commits into from
Jul 26, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jul 24, 2023 •
edited
Loading

In this PR, dpctl.tensor.round is implemented and tested.
Present implementation relies on vector engines of GPU using rounding mode 'round_to_nearest'. Should this change this implementation might break.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@vtavana vtavana self-assigned this Jul 24, 2023
@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1299/index.html

@coveralls
Copy link
Collaborator

coveralls commented Jul 24, 2023 •
edited
Loading

Coverage Status

coverage: 83.239% (+0.003%) from 83.236% when pulling fb35be7 on impl_elementwise_func_round into 616c21e on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_24 ran successfully.
Passed: 484
Failed: 516
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_29 ran successfully.
Passed: 486
Failed: 514
Skipped: 119

@vtavana vtavana force-pushed the impl_elementwise_func_round branch from 37c7b2a to 6ba7391 Compare July 25, 2023 17:57
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_29 ran successfully.
Passed: 488
Failed: 512
Skipped: 119

@vtavana vtavana force-pushed the impl_elementwise_func_round branch from 6ba7391 to fb35be7 Compare July 25, 2023 19:19
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_29 ran successfully.
Passed: 487
Failed: 513
Skipped: 119

ndgrigorian
ndgrigorian approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@oleksandr-pavlyk
Copy link
Collaborator

Perhaps it is worth remarking that present implementation relies on vector engines of GPU using rounding mode 'round_to_nearest'. Should this change this implementation might break. This is why I was insisting that the rounding_func be modularized. It would need to be changed in a single place should it become necessary.

With this remark, it looks good to me too.

@vtavana vtavana merged commit aa7de12 into master Jul 26, 2023
@vtavana vtavana deleted the impl_elementwise_func_round branch July 26, 2023 15:47
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl= ran successfully.
Passed: 566
Failed: 434
Skipped: 119

@ndgrigorian ndgrigorian mentioned this pull request May 29, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtavana @coveralls @oleksandr-pavlyk @ndgrigorian