Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gh 1241 #1319

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Fix gh 1241 #1319

merged 2 commits into from
Aug 3, 2023

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Closes gh-1241 by fixing DLPack exporter logic in dpctl.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Closes gh-1241
c92b503 
The DLPack exporter functionality was not populating strides information
for F-contiguous arrays where usm_ndarray may carry null strides.

This PR changes that fixing the reported bug.
@oleksandr-pavlyk
Add tests based on gh-1241 example
9d2c969
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1319/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 84.806% (+0.01%) from 84.795% when pulling 9d2c969 on fix-gh-1241 into dcca136 on master.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_70 ran successfully.
Passed: 593
Failed: 407
Skipped: 119

antonwolfy
antonwolfy approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine in dpnp test scope also, LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit f65f04a into master Aug 3, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-gh-1241 branch August 3, 2023 17:46
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_87 ran successfully.
Passed: 638
Failed: 362
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dlpack interface with pytorch has unexpected behavior with F-aligned arrays ?
3 participants
@oleksandr-pavlyk @coveralls @antonwolfy