Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes repeat for axis=0 with scalar input #1433

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fixes repeat for axis=0 with scalar input #1433

merged 1 commit into from
Oct 9, 2023

Conversation

ndgrigorian
Copy link
Collaborator

Closes #1432

This PR fixes a bug caused by a typo in the Python binding changes made in #1427

Also adds a test for correct behavior

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian
Fixes gh-1432
3516681 
Caused by a typo in the Python binding changes made in #1427

Added a test for correct behavior
@ndgrigorian ndgrigorian requested a review from npolina4 October 9, 2023 15:41
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1433/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.909%. remained the same when pulling 3516681 on fix-gh-1432 into ebf118a on master.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_7 ran successfully.
Passed: 933
Failed: 67
Skipped: 119

@ndgrigorian ndgrigorian merged commit 6aa8023 into master Oct 9, 2023
@ndgrigorian ndgrigorian deleted the fix-gh-1432 branch October 25, 2023 20:23
@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Jan 26, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npolina4 npolina4 npolina4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

repeat function return incorrect result for axis 0
3 participants
@ndgrigorian @coveralls @npolina4