Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add array API inspection utilities to dpctl.tensor #1469

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Add array API inspection utilities to dpctl.tensor #1469

merged 5 commits into from
Nov 8, 2023

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Nov 6, 2023 •
edited
Loading

This pull request proposes implementing dpctl.tensor.__array_namespace_info__, an inspection utility coming soon to the array API specification.

In addition, this PR adds an __array_api_version__ attribute as per the specification and experimentally removes the --ci flag from array API testing.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian
Adds __array_namespace_info__ inspection utility
f03c18b 
This inspection utility is coming to the array API specification in the near future
@ndgrigorian
Set __array_api_version__ to "2022.12"
91ae646
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1469/index.html

@coveralls
Copy link
Collaborator

coveralls commented Nov 6, 2023 •
edited
Loading

Coverage Status

coverage: 85.811% (+0.02%) from 85.794%
when pulling 412692a on array-api-inspection-utilities
into f686102 on master.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Array API standard conformance tests for dpctl=0.15.1dev1=py310ha25a700_4 ran successfully.
Passed: 1006
Failed: 66
Skipped: 50

oleksandr-pavlyk
oleksandr-pavlyk reviewed Nov 6, 2023
View reviewed changes
dpctl/tensor/_array_api.py Outdated
Comment on lines 117 to 198
def devices(self):
return dpctl.get_devices()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to run in an environment where CUDA device is available, but dpctl was not compiled to offload to NVidia GPUs.

Perhaps we should thin this list by ensuring that we can create an dpt.arange for this device and cache that list.

It does not need to be done in this PR though

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

Array API standard conformance tests for dpctl=0.15.1dev1=py310ha25a700_6 ran successfully.
Passed: 1005
Failed: 67
Skipped: 50

@ndgrigorian ndgrigorian marked this pull request as ready for review November 7, 2023 21:02
@oleksandr-pavlyk
Copy link
Collaborator

The __array_namespace_info__ class would benefit from a docstring, even if concise.

@ndgrigorian
Remove --ci from array API conformity workflow
91b4aaf
@ndgrigorian
Adds __array_namespace_info__ docstrings
68875dc 
Disallows dtypes for `kind` kwarg in __array_namespace_info__().dtypes

Removes  `float16` from dtypes listed by __array_namespace_info__ as per spec

Permits dpctl.tensor.Device objects in device keyword arguments in array API inspection utilities
@ndgrigorian
Adds tests for array API inspection
412692a
@ndgrigorian ndgrigorian force-pushed the array-api-inspection-utilities branch from 13a4262 to 412692a Compare November 8, 2023 09:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Array API standard conformance tests for dpctl=0.15.1dev1=py310ha25a700_16 ran successfully.
Passed: 1006
Failed: 66
Skipped: 50

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian

@ndgrigorian ndgrigorian merged commit f2af753 into master Nov 8, 2023
26 checks passed
@ndgrigorian ndgrigorian deleted the array-api-inspection-utilities branch November 8, 2023 16:38
@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Jan 26, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @oleksandr-pavlyk