Skip to content

Conversation

ndgrigorian
Copy link
Collaborator

This pull request makes changes to sin and expm1 to properly treat real and complex -0 inputs.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Adjusts logic in expm1 and sin for negative 0s inputs in real and complex cases
@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.942%. remained the same
when pulling 1c4b0ab on resolve-gh-1439
into 5ec9fd5 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_18 ran successfully.
Passed: 874
Failed: 57
Skipped: 59

@ndgrigorian ndgrigorian marked this pull request as ready for review November 26, 2023 08:39
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_18 ran successfully.
Passed: 874
Failed: 57
Skipped: 59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants