Skip to content

Conversation

ndgrigorian
Copy link
Collaborator

This pull request adjusts dpctl.tensor.clip to permit min and max to be None simultaneously, resulting in effectively a no-op.

In addition, makes a small adjustment to dpctl.tensor.copy, which would return a TypeError instead of raising it, and resolves #1489 by fixing two typos in _resolve_one_strong_one_weak_types

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

When provided a non-usm_ndarray-input to copy, copy would return the error instead of raising it
@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented Jan 24, 2024

Coverage Status

coverage: 90.974% (+0.3%) from 90.684%
when pulling 5f49400 on clip-array-api-changes
into 5fca9e2 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_28 ran successfully.
Passed: 908
Failed: 1
Skipped: 86

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_29 ran successfully.
Passed: 908
Failed: 1
Skipped: 86

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_32 ran successfully.
Passed: 908
Failed: 1
Skipped: 86

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice to see coverage climb up like this. Thank you @ndgrigorian

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected with DPNP tests now. Thank you @ndgrigorian !

@ndgrigorian ndgrigorian merged commit 8f82fe1 into master Jan 25, 2024
@ndgrigorian ndgrigorian deleted the clip-array-api-changes branch January 25, 2024 16:45
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dpctl could not properly handle NaN edges in clip function

4 participants