Skip to content

Added work-around for breaking change in 2024.1 compiler #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Added work-around for breaking change in 2024.1 compiler #1532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions libsyclinterface/tests/test_sycl_device_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,9 +297,7 @@ TEST_P(TestDPCTLSyclDeviceInterface, ChkGetPreferredVectorWidthDouble)
EXPECT_TRUE(vector_width_double != 0);
}
else {
// FIXME: DPC++ 2023 RT must have a bug, since it returns 1 for
// devices without aspect::fp64
// EXPECT_TRUE(vector_width_double == 0);
EXPECT_TRUE(vector_width_double == 0);
}
}

Expand All @@ -311,7 +309,9 @@ TEST_P(TestDPCTLSyclDeviceInterface, ChkGetPreferredVectorWidthHalf)
if (DPCTLDevice_HasAspect(DRef, DPCTL_SyclAspectToDPCTLAspectType(
DPCTL_StrToAspectType("fp16"))))
{
EXPECT_TRUE(vector_width_half != 0);
// FIXME: zero value incorrectly returned for CPU in 2024.1,
// even though aspect::fp16 is true
EXPECT_TRUE(vector_width_half != 0 || DPCTLDevice_IsCPU(DRef));
}
else {
EXPECT_TRUE(vector_width_half == 0);
Expand Down Expand Up @@ -384,13 +384,14 @@ TEST_P(TestDPCTLSyclDeviceInterface, ChkGetNativeVectorWidthHalf)
if (DPCTLDevice_HasAspect(DRef, DPCTL_SyclAspectToDPCTLAspectType(
DPCTL_StrToAspectType("fp16"))))
{
EXPECT_TRUE(vector_width_half != 0);
// FIXME: zero value incorrectly returned for CPU in 2024.1,
// even though aspect::fp16 is true
EXPECT_TRUE(vector_width_half != 0 || DPCTLDevice_IsCPU(DRef));
}
else {
EXPECT_TRUE(vector_width_half == 0);
}
}
//

TEST_P(TestDPCTLSyclDeviceInterface, ChkGetMaxReadImageArgs)
{
Expand Down