Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coverity issue uninitialized class member #1539

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Fix coverity issue uninitialized class member #1539

merged 2 commits into from
Feb 8, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

This PR fixes Coverity issue: uninitialized dpctl_api class member UAR_BYTE_ and UAR_UBYTE_.

Also sneaks in another constexpr operator call signature for ThreeZeroOffsets_Indexer class.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the fix-coverity-issue-uninitialized-class-member branch from f6a224b to 4e520c6 Compare February 8, 2024 21:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 91.138%. remained the same
when pulling 4e520c6 on fix-coverity-issue-uninitialized-class-member
into 4e95dc3 on master.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_107 ran successfully.
Passed: 907
Failed: 2
Skipped: 86

@oleksandr-pavlyk oleksandr-pavlyk merged commit 8757289 into master Feb 8, 2024
39 of 45 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-coverity-issue-uninitialized-class-member branch February 8, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian