Skip to content

Fix warnings in building libDPPLSyclInterface #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 29, 2020
Merged

Fix warnings in building libDPPLSyclInterface #155

merged 16 commits into from
Oct 29, 2020

Conversation

diptorupd
Copy link
Contributor

Fixes #144

@diptorupd diptorupd self-assigned this Oct 28, 2020
@diptorupd diptorupd marked this pull request as draft October 28, 2020 20:16
Diptorup Deb added 3 commits October 28, 2020 16:50
Add __atrribute__((unused)) to wrap/unwrap functions.
5271051 
    -- Wrap/unwrap functions are imported using the smae macro and
       both versions are not necessarilly used in the same file.
       Adding this attribute prevents a flood of warning.
Remove unused variable.
ed142f3
initialize before use.
1fec3da
@diptorupd diptorupd changed the title Enable warning flags to CXX_FLAGS. Fix warnings in building libDPPLSyclInterface Oct 28, 2020
@oleksandr-pavlyk
Copy link
Contributor

Did you mean to push backends/warning.out?

@diptorupd
Copy link
Contributor Author

@oleksandr-pavlyk Currently we are getting a flood of warning about the tp_print deprecation when we build our extensions. I looked up and these changes relate to PEP 0590 (also refer to https://bugs.python.org/issue37250, cython/cython#2976, cython/cython@f10a0a3).

Based on what I see Cython should only include the tp_print member for when #if PY_VERSION_HEX < 0x030800B1 is satisfied. I am using Python 3.8.5 and still see this warning.

So, the question is how is the PY_VERSION_HEX set by Cython?

There are ways to work around the warning, e.g., https://github.com/openvinotoolkit/openvino/pull/2684/files that we can try. Any thoughts?

@oleksandr-pavlyk
Copy link
Contributor

Cython does not set PY_VERSION_HEX. It comes from Python.h.

Cython may be generating different C/C++ sources based on that value, but Cython does change it AFAIK.

@diptorupd diptorupd marked this pull request as ready for review October 29, 2020 03:37
@diptorupd
Copy link
Contributor Author

diptorupd commented Oct 29, 2020 •
edited
Loading

@oleksandr-pavlyk I fixed all warnings on libDPPLSyclInterface warnings on Linux and Windows. If you can provide some magic for the tp_print flood, we can finally look at a clean build log.

@diptorupd diptorupd marked this pull request as draft October 29, 2020 04:15
@diptorupd diptorupd marked this pull request as ready for review October 29, 2020 14:34
@diptorupd diptorupd merged commit 2010cbb into IntelPython:master Oct 29, 2020
@diptorupd
Copy link
Contributor Author

Merging after testing locally on Windows.

@diptorupd diptorupd deleted the fix/squash_warnings branch October 29, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees

@diptorupd diptorupd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix all warnings
2 participants
@diptorupd @oleksandr-pavlyk