Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport changes from gh-1577 to 0.16.x maintenance branch #1608

Merged
merged 7 commits into from
Mar 27, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk commented Mar 26, 2024

This PR backports fixes from gh-1577.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk oleksandr-pavlyk changed the base branch from master to maintenance/0.16.x March 26, 2024 22:40
@oleksandr-pavlyk
Copy link
Collaborator Author

I think backport should also pick up additional tests

Per array API standard

Also fixes vecdot attempting to call `py_dot` with incorrect batching dims
Only negative values for `axis` are permitted to avoid ambiguity

Now separately checks that the `axis` parameter is valid for each array before broadcasting occurs
Copy link

github-actions bot commented Mar 27, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.16.0=py310h15de555_20 ran successfully.
Passed: 839
Failed: 0
Skipped: 92

@oleksandr-pavlyk oleksandr-pavlyk merged commit e3fb7b3 into maintenance/0.16.x Mar 27, 2024
47 of 49 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the backport-gh-1577 branch March 27, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants