-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiling for CUDA with 2024.1 compiler #1630
Conversation
…floor` with `sycl` variants This is necessitated by issues linking when building for CUDA using 2024.1 compiler
@oleksandr-pavlyk |
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_162 ran successfully. |
The issue that was being work arround has been fixed in 2024.1 compiler
I have pushed a commit to remove the work-around. Local tests passed. |
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_163 ran successfully. |
#ifdef USE_SYCL_FOR_COMPLEX_TYPES | ||
return exprm_ns::abs(exprm_ns::complex<realT>(z)); | ||
#else | ||
return std::hypot(std::real(z), std::imag(z)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return std::hypot(std::real(z), std::imag(z)); | |
return std::hypot(x, y); |
Using the 2024.1 compiler and building with
DPCTL_TARGET_CUDA=1
fails due to unrecognized symbols in elementwise functions likefabs
,fabsf
,copysign
, andfloor
from the C++ std namespace.This PR proposes replacing the non-working symbols with their Sycl namespace equivalents.