Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak scheduling parameter of elementwise operations #1651

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

For contiguous inputs, bump local-work-group size from 64 to 128 work-items.

This change is guided by performance study on Newton root finding example rich in elementwise operations.

With this change, unitrace states that 311 invocations of the kernel took 2805824666 ns, before that, with 64 workitems, the time was 3475091844 ns.

                                                      "dpctl::tensor::kernels::multiply::multiply_inplace_contig_kernel<std::complex<float>, std::complex<float>, 4u, 2u>[SIM
D16 {15625; 1; 1} {128; 1; 1}]",          311,           2805824666,    25.380501,              9021944,              8915416,              9143437                          
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Apr 23, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 88.21%. remained the same
when pulling a906203 on increase-lws-for-elementwise-operations
into 7757857 on master.

Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_302 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit ef5a751 into master Apr 23, 2024
56 of 60 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the increase-lws-for-elementwise-operations branch April 23, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants