Expose DLDeviceType enumerator in dpctl.tensor
#1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_246 ran successfully. |
ndgrigorian
force-pushed
the
document-dldevicetype-constants
branch
from
a416a27 to
c489c7e
Compare
ndgrigorian
force-pushed
the
document-dldevicetype-constants
branch
from
c489c7e to
353be0d
Compare
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_246 ran successfully. |
1 similar comment
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_246 ran successfully. |
oleksandr-pavlyk
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
LGTM! Thank you @ndgrigorian
The constants page fits right in!
oleksandr-pavlyk
merged commit 2bd92df
into
feature/dlpack-kdlcpu-support
48 of 49 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the
DLDeviceTypeenumerators in dpctl.tensor.Additionally, this PR adds documentation for the enumerator values based on the documentation in
dlpack.hand addstensor.constants.rstwhich contains this documentation, as well as documentation ondpt.pi,dpt.e, etc.