Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pybind11 2.13.5 to build dpctl and examples #1812

Merged
merged 2 commits into from
Aug 24, 2024
Merged

Use pybind11 2.13.5 to build dpctl and examples #1812

merged 2 commits into from
Aug 24, 2024

Conversation

ndgrigorian
Copy link
Collaborator

This PR updates dpctl to use the latest pybind11 release.

Experimentally updating examples to use the latest version as well.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_351 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.903%. remained the same
when pulling 83846ac on update-pybind11-2.13.5
into 6cab90c on master.

@ndgrigorian ndgrigorian marked this pull request as ready for review August 24, 2024 19:49
oleksandr-pavlyk
oleksandr-pavlyk approved these changes Aug 24, 2024
View reviewed changes
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating these @ndgrigorian !

@ndgrigorian ndgrigorian merged commit e528f50 into master Aug 24, 2024
47 of 53 checks passed
@ndgrigorian ndgrigorian deleted the update-pybind11-2.13.5 branch August 24, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @oleksandr-pavlyk