Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI failure for conda package workflow on Windows #1831

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Fix CI failure for conda package workflow on Windows #1831

merged 3 commits into from
Sep 13, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Try not building for 3.9 to check if this fixes CI

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_23 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Sep 12, 2024 •
edited
Loading

Coverage Status

coverage: 87.907%. remained the same
when pulling 5faef12 on fix-build-windows-workflow
into 109b4c2 on master.

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the fix-build-windows-workflow branch from d656bf0 to 127d403 Compare September 12, 2024 12:59
@oleksandr-pavlyk oleksandr-pavlyk changed the title Drop building/testing for Python 3.9 Triage CI failure Sep 12, 2024
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_23 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the fix-build-windows-workflow branch from 127d403 to 231bc42 Compare September 12, 2024 13:58
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_23 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the fix-build-windows-workflow branch 2 times, most recently from 9d7ee8d to 43e3eb1 Compare September 12, 2024 15:20
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_23 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_24 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_24 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_25 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the fix-build-windows-workflow branch 2 times, most recently from ce1bcf8 to 76f231a Compare September 12, 2024 21:12
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_34 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

1 similar comment
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_34 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_35 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the fix-build-windows-workflow branch from bf2c04a to 0dc9b25 Compare September 13, 2024 03:02
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_38 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

1 similar comment
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_38 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@oleksandr-pavlyk
Changes to fix Windows build step in conda-package workflow
e70a2f1 
Install conda build as a separate step

This way conda build is installed in base environment of the
miniforge, rather than underlying miniconda3

Correct CONDA_BLD value for build_windows set of conda-packages
@oleksandr-pavlyk
Use mambaforge variant
0e1d166
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the fix-build-windows-workflow branch from 0dc9b25 to 0e1d166 Compare September 13, 2024 10:47
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_37 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_38 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review September 13, 2024 13:37
@oleksandr-pavlyk oleksandr-pavlyk merged commit 156ce3c into master Sep 13, 2024
53 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-build-windows-workflow branch September 13, 2024 16:04
@oleksandr-pavlyk oleksandr-pavlyk changed the title Triage CI failure Fix CI failure for conda package workflow on Windows Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian