-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify iteration space as static library #1847
Simplify iteration space as static library #1847
Conversation
Link that library into Python extensions implementing dpctl.tensor
On rather beefy server, the build time improved very slightly, as reported by
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_66 ran successfully. |
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_67 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested changes locally and it works fine. Extensions which leverage simplify_iteration_space
also build correctly.
LGTM!
Compiled for CUDA target. The test suite run was a PASS. |
The "simplify_iteration_space.cpp" was being compiled as source for every pybind11 native extension.
This change compiles it as a static library once, and links the library into pybind11 native extension modules, shaving some build time.
"simplify_iteration_space.cpp" also no longer includes "dpctl4pybind11.hpp", and hence does not need SYCL target enabled, compiling it as ordinary host code.