-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll must reduce shift steps by size along axis #1869
Roll must reduce shift steps by size along axis #1869
Conversation
Closes gh-1857 Test added based on example provided in the issue.
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_137 ran successfully. |
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_138 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems to have introduced a failure in an array API test
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_142 ran successfully. |
@ndgrigorian I have pushed a fix to this issue, and added tests to cover it. |
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_143 ran successfully. |
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_144 ran successfully. |
Interestingly, I can not reproduce this issue in AWS, neither running an individual test file:
nor running the entire test suite:
|
Also created test environment from the artifact built by |
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_145 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this change out and it seems to be working as expected.
The tests could include one with a very large (in magnitude) negative number but I don't think it's necessary. I did test that case out and it worked as expected too.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for resolving the issue @oleksandr-pavlyk
Closes gh-1857
Test added based on example provided in the issue.