Contribution to 1894 #1895
Merged
Contribution to 1894 #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved common constexpr variables out of branches. Replaced `static constexpr` with `constexpr`. Since these are defined in procedure scope, `static` is not required. Introduced typed temporary variables, so that type deduction for `sycl::min`, `sycl::max`, `sycl::clamp` can work and removed explicit use of their template parameter. Added explicit static_cast on value of `projected` variable computed as IndT type.
This is possible because ProjectorT is literal type (no state and default constructor).
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_208 ran successfully. |
ndgrigorian
approved these changes
Nov 15, 2024
oleksandr-pavlyk
merged commit 6dc298c
into
fix-indexing-oob-indices
48 of 51 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes build break in gh-1894.
In
indexing_utils.hppI moved common constexpr variables out of branches .Replaced
static constexprwithconstexpr. Since these aredefined in procedure scope,
staticis not required.Introduced typed temporary variables, so that type deduction
for
sycl::min,sycl::max,sycl::clampcan work and removedexplicit use of their template parameter.
Added explicit static_cast on value of
projectedvariablecomputed as IndT type.
In
integer_advanced_indexing.hpp, I madeProjectT projconstexpr.