Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve interoperability between SyclDevice and DLPack devices #1953

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improve interoperability between SyclDevice and DLPack devices #1953

wants to merge 5 commits into from
+125 −3

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Jan 4, 2025 •
edited
Loading

This PR proposes improving dpctl's interoperability with DLPack by

  • Adding a new method get_device_id to dpctl.SyclDevice which returns the ordinal ID of a root device
  • Adding new functions dpctl.tensor.dldevice_to_sycldevice and its converse dpctl.tensor.sycldevice_to_dldevice which function as conversions between dpctl.SyclDevices and the DLPack device tuples returned by arr.__dlpack_device__() for some array arr from an arbitrary array library

Closes #1929

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

oleksandr-pavlyk
oleksandr-pavlyk reviewed Jan 4, 2025
View reviewed changes
dpctl/tensor/_dldevice_conversions.py Outdated Show resolved Hide resolved
dpctl/tensor/_dldevice_conversions.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1953/index.html

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_368 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@ndgrigorian ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch 2 times, most recently from ac69747 to eb7f4fe Compare January 7, 2025 18:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_411 ran successfully.
Passed: 893
Failed: 3
Skipped: 118

@coveralls
Copy link
Collaborator

coveralls commented Jan 7, 2025 •
edited
Loading

Coverage Status

coverage: 87.738% (+0.02%) from 87.716%
when pulling f010c23 on dlpack-enum-sycl-device-interop
into a7ca491 on master.

@ndgrigorian ndgrigorian force-pushed the dlpack-enum-sycl-device-interop branch from eb7f4fe to c529b29 Compare January 7, 2025 22:05
@ndgrigorian ndgrigorian marked this pull request as ready for review January 7, 2025 22:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_413 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_415 ran successfully.
Passed: 893
Failed: 3
Skipped: 118

oleksandr-pavlyk
oleksandr-pavlyk reviewed Jan 10, 2025
View reviewed changes
dpctl/_sycl_device.pyx
cdef int dev_id = -1

if self.parent_device:
raise TypeError("This SyclDevice is not a root device")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
raise TypeError("This SyclDevice is not a root device")
raise ValueError("This SyclDevice is not a root device")

oleksandr-pavlyk
oleksandr-pavlyk reviewed Jan 10, 2025
View reviewed changes
dpctl/_sycl_device.pyx
@@ -2045,6 +2043,18 @@ cdef class SyclDevice(_SyclDevice):
else:
return str(relId)

def get_device_id(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a docstring

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function requires self to an unpartitioned device. It is useful to add function SyclDevice.get_unpartitioned_parent_device to return the unpartitioned parent device that this device was obtained from.

oleksandr-pavlyk
oleksandr-pavlyk reviewed Jan 10, 2025
View reviewed changes
dpctl/tensor/_dldevice_conversions.py
from ._usmarray import DLDeviceType


def dldevice_to_sycldevice(dl_dev: tuple):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debating dldevice_to_sycldevice vs dldevice_to_sycl_device.

@ndgrigorian
Copy link
Collaborator Author

@icfaust
This PR implements new DLPack functions in line with your request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: create SyclDevice and attribute to and from dlpack Enum in Python
3 participants
@ndgrigorian @coveralls @oleksandr-pavlyk