Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Run array API conformity with 2024.12 spec #2021

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ndgrigorian
Copy link
Collaborator

This PR experiments with running array API conformity tests with ARRAY_API_TESTS_VERSION=2024.12

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Mar 1, 2025

Copy link

github-actions bot commented Mar 1, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_14 ran successfully.
Passed: 1057
Failed: 8
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Mar 1, 2025

Coverage Status

coverage: 86.734% (-0.02%) from 86.752%
when pulling 3ca6255 on experimentally-use-array-api-version-2024.12
into 579d2f8 on master.

@ndgrigorian ndgrigorian force-pushed the experimentally-use-array-api-version-2024.12 branch from fc9bea6 to 015cae9 Compare March 28, 2025 03:03
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_73 ran successfully.
Passed: 1085
Failed: 7
Skipped: 119

array API 2024 spec requires advanced indexing with integer arrays, and when advanced indexing behavior is triggered, integral scalars are to be converted to arrays and broadcast with the other indices
this fixes cases like `x[..., arr1, int1, arr2, int2, :, int3]`, the final int will be treated as an integer instead of an array, and `arr1` through `int2` will be treated as arrays
since the index is on the host, we can raise like we normally would, which follows NumPy behavior
@ndgrigorian ndgrigorian force-pushed the experimentally-use-array-api-version-2024.12 branch from 015cae9 to 3ca6255 Compare March 31, 2025 23:23
Copy link

github-actions bot commented Apr 1, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_87 ran successfully.
Passed: 1088
Failed: 4
Skipped: 119

@ndgrigorian
Copy link
Collaborator Author

@antonwolfy
all of the array API tests for advanced indexing seem to pass when rebased onto the advanced indexing PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants