Update integer advanced indexing for array API 2024.12 spec #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndgrigorian
requested review from
antonwolfy,
vlad-perevezentsev and
vtavana
as code owners
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2032/index.html |
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_75 ran successfully. |
ndgrigorian
force-pushed
the
update-indexing-for-array-api-2024
branch
from
619dbfd to
a02b5e5
Compare
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_78 ran successfully. |
antonwolfy
reviewed
Apr 1, 2025
ndgrigorian
force-pushed
the
update-indexing-for-array-api-2024
branch
from
a02b5e5 to
71ca729
Compare
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_104 ran successfully. |
array API 2024 spec requires advanced indexing with integer arrays, and when advanced indexing behavior is triggered, integral scalars are to be converted to arrays and broadcast with the other indices
this fixes cases like `x[..., arr1, int1, arr2, int2, :, int3]`, the final int will be treated as an integer instead of an array, and `arr1` through `int2` will be treated as arrays
since the index is on the host, we can raise like we normally would, which follows NumPy behavior
Reduces code duplication
Typos from advanced indexing updates
ndgrigorian
force-pushed
the
update-indexing-for-array-api-2024
branch
from
71ca729 to
d426408
Compare
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_109 ran successfully. |
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_110 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array API specification now requires advanced integer indexing (i.e., with arrays) to promote Python integer scalars to arrays when mixed with integer arrays.
This PR implements this behavior, promoting any integer indices and fixes a bug in indexing where integer indices from 0D arrays were being brought to the host as Python scalars
With the previous behavior, 0D arrays and integer scalars were considered on the same level, and when positioned between two non-0D arrays, would throw
IndexError, noting that basic slicing is not permitting between advanced indices. With the new behavior, an exception is made for integer indices after index arrays but prior to other basic slicing operations, these are now considered on the level of arrays instead, and are promoted to arrays prior to kernel launch.