Use public keyword in _sycl_core.pxd on SyclContext/SyclQueue #218
+26
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Further decoration of |
diptorupd
reviewed
Feb 20, 2021
| @@ -28,7 +28,7 @@ from .._sycl_device cimport SyclDevice | |||
| from .._sycl_queue cimport SyclQueue | |||
|
|
|||
|
|
|||
| cdef class _Memory: | |||
| cdef public class _Memory [object Py_MemoryObject, type Py_MemoryType]: | |||
There was a problem hiding this comment.
Do we need to expose the _Memory class?
There was a problem hiding this comment.
I thought yes. Mostly for type detection. Testing that an object obj is a USM memory buffer can be as simpler as using PyObject_TypeCheck with Py_MemoryType.
oleksandr-pavlyk
force-pushed
the
sycl_core-add-public
branch
from
e83f1e7 to
eda6a92
Compare
|
I thought this change should make it into 0.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes Cython to convert
_sycl_core.pxd,_sycl_core.pyxinto
_sycl_core.hand_sycl_core.cpp.The header file can be used by external C++/C projects to be aware
of SyclContext and SyclQueue python objects defined by dpctl.
These are PySyclContextObject, PySyclQueueObject, which are instances
of PyObject, and
PySyclContextType,PySyclQueueTypewhich can be usedin
PyObject_TypeCheckcalls, validating that a Python object isa valid
syclobjentry in__sycl_usm_array_interface__.