Skip to content

Conversation

@ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Nov 19, 2025

This PR proposes updating the vendored DLPack header dlpack.h to v1.2 and adds data type code and device type enum definitions where necessary

It does not work towards supporting the new C functions to optimize speed of exchange, which could be done in a follow-up PR

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 86.283% (+0.007%) from 86.276%
when pulling 68c2167 on update-dlpack-v1.2
into 70920d3 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_26 ran successfully.
Passed: 1110
Failed: 48
Skipped: 82

kDLWebGPU
kDLHexagon
kDLMAIA
kDLTrn
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we need to update numpy_to_dlpack_versioned_capsule at line following dlpack changes added in v1.2
NumPy did that here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I didn't think we would need to make a change for that part, but I'll adjust it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants